[DNM] Resharper cleanup

[nschonni]

Through the base through ReSharper to see what it could come up with. There is some other stuff, but this was the simplest pieces to see if there is an interest.

[mgreter]

Looks fine for me. I actually expected some warnings in clang or gcc, but they all seem to agree. Not sure if some older compilers will warn missing return when a throw is in place. But CI seems to agree here!

[nschonni]

@mgreter I left all the commits discrete if you want to cherrypick parts, or I can fastforward the branch with the latest.
PS: There were more warnings, these where just the simple stuff

[xzyfer]

There are bits and pieces I'll cherry-pick onto to master. I'll take care of it this weekend. Thanks Nick. Regards, Michael

…

On Fri, Jan 6, 2017 at 10:43 AM, Nick Schonning ***@***.***> wrote: @mgreter <https://github.com/mgreter> I left all the commits discrete if you want to cherrypick parts, or I can fastforward the branch with the latest. PS: There were more warnings, these where just the simple stuff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#2283 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAjZWIpWJiuiKyPnYindMGpSaVsY4zmPks5rPYAQgaJpZM4LaIxy> .

[xzyfer]

@nschonni there has been a lot of churn on master. Want to give this another shot?

[nschonni]

@xzyfer you mentioned you wanted to cherry-pick some stuff. I can do specific PRs for the parts if you call them out here

[xzyfer]

On my phone now. Iirc my main gripe was with renaming variables like lhs and rhs with have a semantic meaning and make the code easier to reason about. On 26 Jan. 2017 2:27 pm, "Nick Schonning" <[email protected]> wrote: @xzyfer <https://github.com/xzyfer> you mentioned you wanted to cherry-pick some stuff. I can do specific PRs for the parts if you call them out here — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2283 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAjZWEf3TO93X7vtYPiHAdHyl3QE5kk2ks5rWBKNgaJpZM4LaIxy> .

[am11]

Nice cleanup! 👍

Related to this, would it be a good idea to have .clang-format rules file like this and make TravisCI do the linting based on the clang-format per PR like these guys are doing? Then in our contribution guide, we can say something this effect:

To avoid build failures due to code formatting, make sure to run .clang-format before issuing the pull request. On Windows, you can use Clang-Format extension for VS.

[nschonni]

Rebased, but I'm going to need to go back and redo some stuff because of the switch to using Cast

[xzyfer]

@am11 omg I've been dreaming about something like .clang-format. I couldn't find docs on a prevailing convention or tool for this stuff.

[mgreter]

Interestingly there seems to have been a reason for these superflous returns ...

[mgreter]

Rebased and cherry picked in #2316

[mgreter]

Closing this as most has been merged with #2316. Thanks @nschonni!