Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

Bourbon's transition mixin doesn't work with transform #1227

Closed
akheron opened this issue Oct 29, 2015 · 7 comments
Closed

Bourbon's transition mixin doesn't work with transform #1227

akheron opened this issue Oct 29, 2015 · 7 comments

Comments

@akheron
Copy link

akheron commented Oct 29, 2015

Here's my scss file:

@import 'bourbon';
body {
    @include transition(transform 0.3s ease);
}

With ruby sass I get the following correct output:

$ sass test.scss
body {
  -webkit-transition: -webkit-transform 0.3s ease;
  -moz-transition: -moz-transform 0.3s ease;
  transition: transform 0.3s ease; }

With node-sass I get the following incorrect output:

$ node-sass test.scss
body {
  -webkit-transition: -webkit-transform;
  -moz-transition: -moz-transform;
  transition: transform; }

I've debugged this, and it seems to boil down to an issue with variable arguments and iterating over them with @each. Here's another test file:

@mixin test-varargs-and-each($properties...) {
    @each $list in $properties {
        @debug $list;
    }
}
@include test-varargs-and-each(first second third);

With ruby sass:

$ sass test2.scss
test2.scss:3 DEBUG: first second third

With node-sass:

$ node-sass test2.scss
test2.scss:3 DEBUG: first

So it looks as if the list was somehow truncated to only contain the first item by @each.

UPDATE: Fixed sass outputs for the bourbon test

@akheron
Copy link
Author

akheron commented Oct 29, 2015

Version info for the broken case:

$ node-sass --version
node-sass       3.4.1   (Wrapper)       [JavaScript]
libsass         3.3.1   (Sass Compiler) [C/C++]

It seems to work correctly with node-sass 3.3.3 and libsass 3.2.5.

@raldred
Copy link

raldred commented Nov 26, 2015

I'm up against this issue too
So the only solution thus far is to downgrade node-sass?

@akheron
Copy link
Author

akheron commented Nov 27, 2015

I found no other solution than to downgrade node-sass to 3.3.3.

@brianreavis
Copy link

@raldred @akheron That or override the transition mixin: thoughtbot/bourbon#794 (comment)

@xzyfer
Copy link
Contributor

xzyfer commented Nov 28, 2015

Thanks for the report. Apologies for the delay I've been away. This is a known issue the latest LibSass sass/libsass#1645

A fix is planned next LibSass release.

@xzyfer xzyfer added this to the next.libsass milestone Nov 28, 2015
@xzyfer xzyfer self-assigned this Nov 28, 2015
@raldred
Copy link

raldred commented Nov 28, 2015

thanks @brianreavis that works in the interim, thanks.
@xzyfer no problem thanks for the update.

@xzyfer
Copy link
Contributor

xzyfer commented Jan 20, 2016

This is fixed in the upcoming 3.5.0-beta. Subscribe to #1349 for further updates.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants