Upgrade version of node-sass #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Despite the latest version of node-sass (3.5.0-beta.1) being listed, I can't install it. npm just keeps installing the latest stable, 3.4.2. So I'm downgrading node-sass to 3.3.3, the last stable version before the issue in question with LibSass was introduced. Will keep an eye on node-sass to see when 3.5.0 becomes stable and will upgrade to that when the time comes. |
|
I've also set broccoli-sass to look for the latest minor release, instead of being locked to 0.6.6. |
Downgraded node-sass to 3.3.3; Set broccoli-sass to look for minor releases.
|
@nathanhebe could you run npm-install in this branch and check everything works for you? Aside from nothing breaking, you should see the toolbox and bottom drawer animate again when opening and closing. |
|
+1 |
|
Have raised an issue (#66) to keep track of this. |
# Conflicts: # package.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's an issue in LibSass that's preventing some Bourbon mixins from compiling out correctly. Going to upgrade the version of node-sass to a version which fixes this issue.