This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
Bump almost all deps and remove npmconf #1413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- get-stdin v5.0.0 and v5.0.1 both changed the API and use Promises. Possibly look at the 'then/promise' module to shim. - switched to cross-spawn-async as no spawning is done synchronously, so using more specific dependency. - graceful-fs warning is due to mocha being tardy itself.
|
Thanks @delitescere. At first glance things look good. I'll take a closer look tomorrow. |
xzyfer
added a commit
that referenced
this pull request
Mar 19, 2016
Bump almost all deps and remove npmconf
hale
added a commit
to hale/adminApplicationsReact
that referenced
this pull request
Mar 19, 2016
* Waiting on version bump of node-sass to bring in sass/node-sass#1413
xzyfer
added a commit
to xzyfer/node-sass
that referenced
this pull request
Apr 27, 2016
This was previous attemped in sass#1413 but it missed some important edge cases and partly responsible for installion issues with proxies users. This patch takes the [advice of the npm team][1]. Instead of trying to reverse engineer the npm config internals we're simply asking npm for it's config. It's a bit slower but this only happens during installation so I'm ok with it. Fixes sass#1333 [1:][npm/npmconf#61 (comment)]
xzyfer
added a commit
to xzyfer/node-sass
that referenced
this pull request
Apr 27, 2016
This was previously attempted in sass#1413. Shortly after it's release proxy users started experiencing installation issues so this was reverted. It was later determined that sass#1458 was likely at fault for the proxy issues. Full credit for this patch goes to @delitescere. I've also taken the liberty of cleaning the request config generation. Fixes sass#1333
xzyfer
added a commit
to xzyfer/node-sass
that referenced
this pull request
Apr 27, 2016
This was previously attempted in sass#1413. Shortly after it's release proxy users started experiencing installation issues so this was reverted. It was later determined that sass#1458 was likely at fault for the proxy issues. Full credit for this patch goes to @delitescere. I've also taken the liberty of cleaning the request config generation. Fixes sass#1333
xzyfer
added a commit
to xzyfer/node-sass
that referenced
this pull request
Apr 27, 2016
This was previously attempted in sass#1413. Shortly after it's release proxy users started experiencing installation issues so this was reverted. It was later determined that sass#1458 was likely at fault for the proxy issues. Full credit for this patch goes to @delitescere. I've also taken the liberty of cleaning the request config generation. Fixes sass#1333
xzyfer
added a commit
to xzyfer/node-sass
that referenced
this pull request
Apr 27, 2016
This was previously attempted in sass#1413. Shortly after it's release proxy users started experiencing installation issues so this was reverted. It was later determined that sass#1458 was likely at fault for the proxy issues. Full credit for this patch goes to @delitescere. I've also taken the liberty of cleaning the request config generation. Fixes sass#1333
xzyfer
added a commit
that referenced
this pull request
Apr 28, 2016
This was previously attempted in #1413. Shortly after it's release proxy users started experiencing installation issues so this was reverted. It was later determined that #1458 was likely at fault for the proxy issues. Full credit for this patch goes to @delitescere. I've also taken the liberty of cleaning the request config generation. Fixes #1333
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates almost all the dependencies and fixes issue #1333
get-stdinas v5.0.0 and v5.0.1 both changed the API and use Promises. Possibly look at the 'then/promise' module to shim.cross-spawn-asyncas no spawning is done synchronously, so using more specific dependency.graceful-fswarning is due to mocha being tardy itself.Tests pass on node v0.10, v0.12, v4.4.0. No additional tests created, however manual testing of
HTTP_PROXY=x npm ...andnpm config set proxy x; npm ...was done to verify thenpmconfremoval and change ininstall.jsworks.