Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ruff linting in notebooks 🏅 #960

Closed
janfb opened this issue Feb 28, 2024 · 0 comments · Fixed by #978
Closed

Fix ruff linting in notebooks 🏅 #960

janfb opened this issue Feb 28, 2024 · 0 comments · Fixed by #978
Labels
bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request hackathon karma Karma issues: potentially annoying but very important issues
Milestone
Hackathon and rel...

Comments

@janfb
Copy link
Contributor

janfb commented Feb 28, 2024

Same problem as described in #959 , but in examples and notebooks. Should be addressed together with or after #959

To fix this, uncomment

# extend-include = ["*.ipynb"]`

in pyproject.toml, run ruff lint . locally and fix all the errors.
@janfb janfb added bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request hackathon labels Feb 28, 2024
@janfb janfb added this to the Hackathon 2024 milestone Feb 28, 2024
@janfb janfb added the karma Karma issues: potentially annoying but very important issues label Feb 28, 2024
janfb added a commit that referenced this issue Mar 6, 2024
@janfb
fix #960: ruff linting in all notebooks
d2cf1f1
janfb added a commit that referenced this issue Mar 6, 2024
@janfb
fix #960: ruff linting in all notebooks
a68d949
janfb added a commit that referenced this issue Mar 6, 2024
@janfb
fix #960: ruff linting in all notebooks
9b07b1f
@janfb janfb mentioned this issue Mar 6, 2024
Merged
janfb added a commit that referenced this issue Mar 12, 2024
@janfb
fix #960: ruff linting in all notebooks
29fde7c
@janfb janfb closed this as completed in 3fd81b6 Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request hackathon karma Karma issues: potentially annoying but very important issues
Projects
None yet
Milestone
Hackathon and release 0.23
Development

Successfully merging a pull request may close this issue.

use ruff for linting and formatting, update CI sbi-dev/sbi
1 participant
@janfb