-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
importance sampling posterior #1183
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1183 +/- ##
==========================================
- Coverage 81.76% 73.30% -8.47%
==========================================
Files 93 93
Lines 7448 7458 +10
==========================================
- Hits 6090 5467 -623
- Misses 1358 1991 +633
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks @manuelgloeckler! Make sure to fix the pyright error, I've marked what I think is causing it.
Great, thanks for the pyright fix. Your suggestions resolved it. |
What does this implement/fix? Explain your changes
Adds the possibility of importance sampling.
Does this close any currently open issues?
Fixes #919
Any other comments?