-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor diagnostics #1196
Refactor diagnostics #1196
Conversation
59c0c70
to
6829e2a
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1196 +/- ##
==========================================
- Coverage 84.35% 75.85% -8.51%
==========================================
Files 96 97 +1
Lines 7702 7673 -29
==========================================
- Hits 6497 5820 -677
- Misses 1205 1853 +648
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has a lot of overlap with the PR with the test for MDN calibration, which one should I review?
this one please. The MDN only adds the test, but copied all the changes from here. |
e5938ff
to
931892f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! A few comments below.
931892f
to
84e3f3d
Compare
97262e0
to
5f89123
Compare
5ae425d
to
8a7f4b0
Compare
8a7f4b0
to
66e3b83
Compare
What does this implement/fix? Explain your changes
run_sbc
orrun_tarp
will do everything for the user, including posterior sampling. But now it is possible to first obtain posteroir samples and then pass them to_run_sbc
and then to_run_tarp
, without having to generate them again.