make transform optional for DirectPosterior. #714
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #713
Before this PR, the
DirectPosterior
was constructing atheta_transform
from the prior support by default and used it for maybe calculating the MAP. This can cause issues if a custom prior has a funky support.This PR adds the
theta_transform = None
argument to theDirectPosterior
top level so that users can pass anIdentityTransform
to avoid the default construction of a transform to unconstrained space. If the argument is leftNone
the support of the prior is used to construct a transform -- as before.