Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cnn shapes in loop #769

Merged
merged 1 commit into from
Nov 3, 2022
Merged

cnn shapes in loop #769

merged 1 commit into from
Nov 3, 2022

Conversation

michaeldeistler
Copy link
Contributor

@michaeldeistler michaeldeistler commented Nov 3, 2022 •
edited
Loading

This is a PR to be merged into your CNN branch.

Not sure if I missed something in the implementation, but the tests pass.

@michaeldeistler michaeldeistler requested a review from janfb November 3, 2022 07:34
janfb
janfb approved these changes Nov 3, 2022
View reviewed changes
Copy link
Contributor

@janfb janfb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me!

@janfb janfb merged commit 0d66e3a into fix-cnn-embedding Nov 3, 2022
@janfb janfb deleted the cnn-embedding-loop branch November 3, 2022 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janfb janfb janfb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michaeldeistler @janfb