Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support SSH and Git protocol remote URLs #112

Merged
merged 1 commit into from
Apr 21, 2020

Conversation

cb372
Copy link
Contributor

@cb372 cb372 commented Apr 21, 2020

When extracting the SCM info from the git remote URL:

  • Support HTTPS, SSH and git protocols
  • Support URLs with the optional .git suffix

When extracting the SCM info from the git remote URL:

* Support HTTPS, SSH and git protocols
* Support URLs with the optional `.git` suffix
@cb372
Copy link
Contributor Author

cb372 commented Apr 21, 2020

A bit of context on the reason for this change: sbt-ci-release populating scmInfo is quite handy and we rely on it in another plugin, but we don't want to force people to clone using HTTPS protocol on developer machines.

Copy link
Member

@olafurpg olafurpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thank you!

@olafurpg olafurpg merged commit b6e352d into sbt:master Apr 21, 2020
@olafurpg
Copy link
Member

Triggered a v1.5.3 release with this fix https://github.com/olafurpg/sbt-ci-release/releases/tag/v1.5.3

@cb372 cb372 deleted the remote-url-other-protocols branch April 21, 2020 13:39
@cb372
Copy link
Contributor Author

cb372 commented Apr 21, 2020

Thanks for the lightning-fast release! It's almost as if you know a thing or two about release automation.

@olafurpg
Copy link
Member

haha 😅

It would be nice if the "Merge pull request" button had a checkbox to "Cut new release after merge", would automate most of the remaining manual tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants