Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial Fix #173: Problems publishing using GitHub actions #174

Merged
merged 3 commits into from
Mar 23, 2021

Conversation

ekrich
Copy link
Contributor

@ekrich ekrich commented Jan 28, 2021

This solves the documentation side from my point of view anyway. Based on the previous diagram it looks like they changed the interface. I think storing the pictures locally may make it easier for contributors.

A couple of the links removed do not exist or the users may not have permissions to the GitHub Settings for example.

I think this should be followed up by a code change to try and fail with more reasonable errors. I finally found the problem by publishing a SNAPSHOT locally and then seeing a different error with the real deploy in CI. The release errors for SNAPSHOT and Tag publish are completely different.

I also noticed that publishLocal artifact name with no settings for dynver and the SNAPSHOT name released in CI are different. The local one has a timestamp and different artifacts can get different timestamps so they don't match.

@ekrich ekrich changed the title Partial Fix #171: Problems publishing using GitHub actions Partial Fix #173: Problems publishing using GitHub actions Feb 13, 2021
Copy link
Member

@olafurpg olafurpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this contribution! Just a small comment on the images, otherwise LGTM

readme.md Outdated
Select `Settings -> Secrets -> New repository secret` to add each of the
required variables as shown in the next figure:

![secrets button 2021-01-27](docs/github-secrets-2021-01-27.png)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These images look empty. Can you upload them to a github issue and use the link instead? My experience is that it's best to avoid committing image files into the git repository.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I understand about not checking images in. I didn't know you could upload them to an issue so I didn't want them on my personal github - I will look into that. It'll take me a couple of days to get to this. Thanks for reviewing.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems ok. I can't seem to understand how to upload a file that is associated with this repo.
https://github.com/olafurpg/sbt-ci-release/tree/c0febea24fe111f80933824656eff90cea42baa9

Base automatically changed from master to main March 11, 2021 09:46
@ekrich
Copy link
Contributor Author

ekrich commented Mar 21, 2021

@olafurpg I finally figured it out - dang, so easy.

github-secrets-2021-01-27

Here is the second one.

github-env-vars-2021-01-27

@ekrich
Copy link
Contributor Author

ekrich commented Mar 21, 2021

@olafurpg I think my issue can be closed with this PR. #173

It would be nice to improve the error handling but that would take someone digging in and working on it.

Copy link
Member

@olafurpg olafurpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thank you!

@olafurpg olafurpg merged commit e5f0396 into sbt:main Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants