-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Partial Fix #173: Problems publishing using GitHub actions #174
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this contribution! Just a small comment on the images, otherwise LGTM
readme.md
Outdated
Select `Settings -> Secrets -> New repository secret` to add each of the | ||
required variables as shown in the next figure: | ||
|
||
 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These images look empty. Can you upload them to a github issue and use the link instead? My experience is that it's best to avoid committing image files into the git repository.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I understand about not checking images in. I didn't know you could upload them to an issue so I didn't want them on my personal github - I will look into that. It'll take me a couple of days to get to this. Thanks for reviewing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems ok. I can't seem to understand how to upload a file that is associated with this repo.
https://github.com/olafurpg/sbt-ci-release/tree/c0febea24fe111f80933824656eff90cea42baa9
@olafurpg I finally figured it out - dang, so easy. Here is the second one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 Thank you!
This solves the documentation side from my point of view anyway. Based on the previous diagram it looks like they changed the interface. I think storing the pictures locally may make it easier for contributors.
A couple of the links removed do not exist or the users may not have permissions to the GitHub
Settings
for example.I think this should be followed up by a code change to try and fail with more reasonable errors. I finally found the problem by publishing a SNAPSHOT locally and then seeing a different error with the real deploy in CI. The release errors for SNAPSHOT and Tag publish are completely different.
I also noticed that
publishLocal
artifact name with no settings fordynver
and the SNAPSHOT name released in CI are different. The local one has a timestamp and different artifacts can get different timestamps so they don't match.