Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(domain): add more filtering options to list tasks #424

Merged
merged 1 commit into from
Feb 6, 2023
Merged

feat(domain): add more filtering options to list tasks #424

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions packages/clients/src/api/domain/v2beta1/api.gen.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -775,14 +775,15 @@ export class API extends ParentAPI {
*/
export class RegistrarAPI extends ParentAPI {
protected pageOfListTasks = (
request: Readonly<RegistrarApiListTasksRequest>,
request: Readonly<RegistrarApiListTasksRequest> = {},
) =>
this.client.fetch<ListTasksResponse>(
{
method: 'GET',
path: `/domain/v2beta1/tasks`,
urlParams: urlParams(
['domain', request.domain],
['order_by', request.orderBy ?? 'domain_desc'],
[
'organization_id',
request.organizationId ??
Expand All @@ -797,6 +798,8 @@ export class RegistrarAPI extends ParentAPI {
'project_id',
request.projectId ?? this.client.settings.defaultProjectId,
],
['statuses', request.statuses],
['types', request.types],
),
},
unmarshalListTasksResponse,
Expand All @@ -808,7 +811,7 @@ export class RegistrarAPI extends ParentAPI {
* @param request - The request {@link RegistrarApiListTasksRequest}
* @returns A Promise of ListTasksResponse
*/
listTasks = (request: Readonly<RegistrarApiListTasksRequest>) =>
listTasks = (request: Readonly<RegistrarApiListTasksRequest> = {}) =>
enrichForPagination('tasks', this.pageOfListTasks, request)

/**
Expand Down
1 change: 1 addition & 0 deletions packages/clients/src/api/domain/v2beta1/index.gen.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,7 @@ export type {
ListRenewableDomainsResponse,
ListSSLCertificatesRequest,
ListSSLCertificatesResponse,
ListTasksRequestOrderBy,
ListTasksResponse,
Nameserver,
NewContact,
Expand Down
15 changes: 14 additions & 1 deletion packages/clients/src/api/domain/v2beta1/types.gen.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,16 @@ export type ListDomainsRequestOrderBy = 'domain_asc' | 'domain_desc'

export type ListRenewableDomainsRequestOrderBy = 'domain_asc' | 'domain_desc'

export type ListTasksRequestOrderBy =
| 'domain_desc'
| 'domain_asc'
| 'type_asc'
| 'type_desc'
| 'status_asc'
| 'status_desc'
| 'updated_at_asc'
| 'updated_at_desc'

export type RawFormat = 'unknown_raw_format' | 'bind'

export type RenewableDomainStatus =
Expand Down Expand Up @@ -1026,9 +1036,12 @@ export type DeleteDNSZoneTsigKeyRequest = {
export type RegistrarApiListTasksRequest = {
page?: number
pageSize?: number
domain: string
projectId?: string
organizationId?: string
domain?: string
types?: TaskType[]
statuses?: TaskStatus[]
orderBy?: ListTasksRequestOrderBy
}

export type RegistrarApiBuyDomainsRequest = {
Expand Down