Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add render objects #111

Merged
merged 26 commits into from
Jan 11, 2024
Merged

refactor: add render objects #111

merged 26 commits into from
Jan 11, 2024

Conversation

schultek
Copy link
Owner

@schultek schultek commented Aug 28, 2023

Description

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • 📝 Documentation
  • 🗑️ Chore

Ready Checklist

  • I've read the Contribution Guide.
  • In case this PR changes one of the core packages, I've modified the respective CHANGELOG.md file using
    the semantic_changelog format.
  • I updated/added relevant documentation (doc comments with ///).

If you need help, consider asking for advice on the #contribute channel on Discord.

@docs-page
Copy link

docs-page bot commented Aug 28, 2023

To view this pull requests documentation preview, visit the following URL:

docs.page/schultek/jaspr~111

Documentation is deployed and generated using docs.page.

@schultek schultek changed the title Improvement/render objects Rendering implementation: add render objects Aug 28, 2023
@github-actions
Copy link

github-actions bot commented Aug 28, 2023

Package Version Report

The following packages have been updated:
jaspr : 0.9.3 -> 0.10.0
jaspr_builder : 0.9.3 -> 0.10.0
jaspr_cli : 0.9.3 -> 0.10.0
jaspr_flutter_embed : 0.1.4 -> 0.1.5
jaspr_riverpod : 0.3.8 -> 0.3.9
jaspr_router : 0.3.0 -> 0.3.1
jaspr_test : 0.9.3 -> 0.10.0

@schultek schultek changed the title Rendering implementation: add render objects Refactor: Add render objects Jan 9, 2024
@schultek schultek changed the title Refactor: Add render objects refactor: add render objects Jan 9, 2024
@schultek schultek marked this pull request as ready for review January 9, 2024 11:26
Kilian Schulte added 2 commits January 11, 2024 12:18
# Conflicts:
#	packages/jaspr/lib/src/framework/framework.dart
Copy link

codecov bot commented Jan 11, 2024

Codecov Report

Attention: 73 lines in your changes are missing coverage. Please review.

Comparison is base (a53c6d9) 61.78% compared to head (5e3f1d2) 61.14%.
Report is 1 commits behind head on main.

Files Patch % Lines
...kages/jaspr/lib/src/browser/dom_render_object.dart 75.71% 17 Missing ⚠️
...ackages/jaspr/lib/src/framework/dom_component.dart 53.12% 15 Missing ⚠️
packages/jaspr/lib/src/framework/notification.dart 0.00% 14 Missing ⚠️
...s/jaspr/lib/src/server/document/base_document.dart 33.33% 12 Missing ⚠️
packages/jaspr/lib/src/framework/framework.dart 82.97% 8 Missing ⚠️
...ackages/jaspr/lib/src/framework/render_object.dart 87.50% 4 Missing ⚠️
packages/jaspr/lib/src/foundation/sync.dart 62.50% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #111      +/-   ##
==========================================
- Coverage   61.78%   61.14%   -0.65%     
==========================================
  Files         102       98       -4     
  Lines        4106     4043      -63     
==========================================
- Hits         2537     2472      -65     
- Misses       1569     1571       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@schultek schultek merged commit 5e3f1d2 into main Jan 11, 2024
7 of 8 checks passed
@schultek schultek deleted the improvement/render_objects branch January 11, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant