Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] Add LS-ConS method #103

Merged
merged 44 commits into from
Mar 4, 2024
Merged

Conversation

antoinecollas
Copy link
Collaborator

This PR implements the LS-ConS method from http://proceedings.mlr.press/v28/zhang13d.pdf (mainly eq.9 and 10).
Related issue: #43

@kachayev kachayev added the algorithm Implementation or improvements of the DA methods label Feb 23, 2024
Copy link

codecov bot commented Feb 23, 2024

Codecov Report

Attention: Patch coverage is 97.64706% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 97.63%. Comparing base (2ba92b4) to head (7475189).

Files Patch % Lines
skada/_mapping.py 97.59% 2 Missing ⚠️
skada/utils.py 91.30% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #103      +/-   ##
==========================================
- Coverage   97.63%   97.63%   -0.01%     
==========================================
  Files          47       47              
  Lines        3758     3925     +167     
==========================================
+ Hits         3669     3832     +163     
- Misses         89       93       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@antoinecollas antoinecollas changed the title [WIP] Add LS-ConS method [TO_REVIEW] Add LS-ConS method Feb 23, 2024
@rflamary rflamary changed the title [TO_REVIEW] Add LS-ConS method [MRG] Add LS-ConS method Mar 4, 2024
@rflamary rflamary merged commit 0deed68 into scikit-adaptation:main Mar 4, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
algorithm Implementation or improvements of the DA methods
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants