rdataframe to awkward

[ianna]

move PR #1448 to a clean branch

[codecov]

Codecov Report

Merging #1474 (6c270d5) into main (5a78305) will decrease coverage by 0.38%.
The diff coverage is 5.10%.

Impacted Files	Coverage Δ
src/awkward/_v2/_connect/cling.py	26.33% <0.00%> (-0.32%)	⬇️
...awkward/_v2/_connect/rdataframe/from_rdataframe.py	0.00% <0.00%> (ø)
...c/awkward/_v2/_connect/rdataframe/to_rdataframe.py	0.00% <0.00%> (ø)
src/awkward/_v2/_util.py	81.83% <25.00%> (-0.35%)	⬇️
src/awkward/_v2/operations/ak_from_rdataframe.py	42.85% <42.85%> (ø)
src/awkward/_v2/operations/__init__.py	100.00% <100.00%> (ø)

[ianna]

@jpivarski - I think, I've addressed all the issues. As discussed, the Awkward array types will be a separate PR. Please, have a look when you have time. Thanks!

[jpivarski]

Very nice! I just have a few changes requested inline, and also this one:

What was the name of the header-only library directory that @ManasviGoyal is filling? Is it src/awkward/_v2/header-only? Could we put ak_array_builders.h there?

src/awkward/_v2/header-only/rdataframe_jagged_builders.h

Also focusing the name of the file on what it does: it makes jagged^N arrays of numbers for RDataFrame.

[ianna]

Very nice! I just have a few changes requested inline, and also this one:

What was the name of the header-only library directory that @ManasviGoyal is filling? Is it src/awkward/_v2/header-only? Could we put ak_array_builders.h there?

src/awkward/_v2/header-only/rdataframe_jagged_builders.h

Also focusing the name of the file on what it does: it makes jaggedN arrays of numbers for RDataFrame.

Thanks! All done.

The file is moved to:

src/awkward/cpp-headers/rdataframe_jagged_builders.h

[jpivarski]

Everything looks great, thanks!

After merging this, I'll start a new release; this will be in it, and that should make it easier for users to try it out and get feedback to you.