Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tuto chen xu #115

Merged
merged 12 commits into from
Jan 21, 2022
Merged

Tuto chen xu #115

merged 12 commits into from
Jan 21, 2022

Conversation

tmorzade
Copy link
Contributor

Description

Add the tuto from the paper of Kim and all including boxplot of width and coverage scores for a series of trial
Detect a bug id classification example

"""
Extension error:
Here is a summary of the problems encountered when running the examples

Unexpected failing examples:
/data/MAPIE/examples/classification/plot_digits_classification.py failed leaving traceback:
Traceback (most recent call last):
File "/data/MAPIE/examples/classification/plot_digits_classification.py", line 167, in
disp1 = metrics.ConfusionMatrixDisplay.from_predictions(
AttributeError: type object 'ConfusionMatrixDisplay' has no attribute 'from_predictions'
"""

  • New feature (non-breaking change which adds functionality)
    New example plt_kim_2020.py

Checklist:

  • I have read the contributing guidelines
  • I have updated the HISTORY.rst and AUTHORS.rst files
  • Linting passes successfully : make lint
  • Typing passes successfully : make type-check
  • Unit tests pass successfully : make tests
  • Coverage is 100% : make coverage
  • Documentation builds successfully : make doc

@codecov-commenter
Copy link

codecov-commenter commented Dec 17, 2021

Codecov Report

Merging #115 (007f7ab) into master (27e7b68) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #115   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           16        16           
  Lines         1122      1142   +20     
  Branches        93        99    +6     
=========================================
+ Hits          1122      1142   +20     
Impacted Files Coverage Δ
mapie/subsample.py 100.00% <ø> (ø)
mapie/metrics.py 100.00% <100.00%> (ø)
mapie/tests/test_metrics.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27e7b68...007f7ab. Read the comment docs.

@tmorzade tmorzade linked an issue Jan 13, 2022 that may be closed by this pull request
Copy link
Collaborator

@gmartinonQM gmartinonQM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again !

Copy link
Collaborator

@gmartinonQM gmartinonQM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ADD] plot_kim2020_simulations.py to examples/regression/
4 participants