Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADD] EnbPI #135

Merged
merged 37 commits into from
Jun 13, 2022
Merged

[ADD] EnbPI #135

merged 37 commits into from
Jun 13, 2022

Conversation

tmorzade
Copy link
Contributor

@tmorzade tmorzade commented Feb 11, 2022 •
edited by vtaquet
Loading

Description

Add a class dedicated for Time Series Regression called MapieTimeSeriesRegressor.

Correspond to Issue #134 .
Also fixes issue #164 .

Type of change

Please remove options that are irrelevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • I have read the contributing guidelines
  • I have updated the HISTORY.rst and AUTHORS.rst files
  • Linting passes successfully : make lint
  • Typing passes successfully : make type-check
  • Unit tests pass successfully : make tests
  • Coverage is 100% : make coverage
  • Documentation builds successfully : make doc

Thomas Morzadec added 2 commits February 8, 2022 17:10
[ADD] EnbPI
a6b1a2b 
Remark: "artifical" alpha=0.5 in partial_fit. Should change regression.py to avoid it
[CHANGE] partial_fit -> partial_update
14552cb
@gmartinonQM gmartinonQM self-assigned this Feb 11, 2022
@tmorzade tmorzade linked an issue Feb 11, 2022 that may be closed by this pull request
[ENHANCEMENT]: MAPIE is not available for Time Series yet #134
Closed
vtaquet
vtaquet reviewed Feb 21, 2022
View reviewed changes
@codecov-commenter
Copy link

codecov-commenter commented Feb 28, 2022 •
edited
Loading

Codecov Report

Merging #135 (3f779ec) into master (f8fc330) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##            master      #135    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           18        20     +2     
  Lines         1348      1661   +313     
  Branches       150       180    +30     
==========================================
+ Hits          1348      1661   +313
Impacted Files Coverage Δ
mapie/tests/test_utils.py 100.00% <ø> (ø)
mapie/_compatibility.py 100.00% <100.00%> (ø)
mapie/regression.py 100.00% <100.00%> (ø)
mapie/subsample.py 100.00% <100.00%> (ø)
mapie/tests/test_regression.py 100.00% <100.00%> (ø)
mapie/tests/test_subsample.py 100.00% <100.00%> (ø)
mapie/tests/test_time_series_regression.py 100.00% <100.00%> (ø)
mapie/time_series_regression.py 100.00% <100.00%> (ø)
mapie/utils.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8fc330...3f779ec. Read the comment docs.

@gmartinonQM gmartinonQM linked an issue Mar 11, 2022 that may be closed by this pull request
[ENHANCEMENT] time series conformal prediction #74
Closed
Thomas Morzadec added 3 commits March 21, 2022 11:19
@bethrice44 bethrice44 mentioned this pull request May 10, 2022
Closed
@vtaquet vtaquet merged commit e49b6c4 into master Jun 13, 2022
@vtaquet vtaquet mentioned this pull request Jun 30, 2022
Closed
@thibaultcordier thibaultcordier deleted the enbpi branch March 3, 2023 15:23
@github-actions github-actions bot mentioned this pull request Jun 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtaquet vtaquet vtaquet left review comments

@gmartinonQM gmartinonQM gmartinonQM left review comments

@JulienRoussel77 JulienRoussel77 Awaiting requested review from JulienRoussel77

Assignees

@gmartinonQM gmartinonQM

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ENHANCEMENT]: MAPIE is not available for Time Series yet [ENHANCEMENT] time series conformal prediction
5 participants
@tmorzade @codecov-commenter @bethrice44 @vtaquet @gmartinonQM