Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix smaller issues; package sorting and documentation #246

Merged
merged 4 commits into from
Jan 3, 2023

Conversation

LacombeLouis
Copy link
Collaborator

@LacombeLouis LacombeLouis commented Jan 3, 2023

Description

Using isort to fix the import of the packages. Fixes issue #245 and issue #244.

Type of change

Please remove options that are irrelevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Checklist

  • I have read the contributing guidelines
  • I have updated the HISTORY.rst and AUTHORS.rst files
  • Linting passes successfully : make lint
  • Typing passes successfully : make type-check
  • Unit tests pass successfully : make tests
  • Coverage is 100% : make coverage
  • Documentation builds successfully : make doc

@LacombeLouis LacombeLouis self-assigned this Jan 3, 2023
@LacombeLouis LacombeLouis linked an issue Jan 3, 2023 that may be closed by this pull request
@LacombeLouis LacombeLouis changed the title fix: using isort on all the python files to arrange packages Fix smaller issues; package sorting and documentation Jan 3, 2023
@LacombeLouis LacombeLouis linked an issue Jan 3, 2023 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Jan 3, 2023

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (ef3069a) compared to base (b75e212).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #246   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           24        24           
  Lines         2450      2447    -3     
  Branches       267       267           
=========================================
- Hits          2450      2447    -3     
Impacted Files Coverage Δ
mapie/__init__.py 100.00% <100.00%> (ø)
mapie/classification.py 100.00% <100.00%> (ø)
mapie/conformity_scores.py 100.00% <100.00%> (ø)
mapie/metrics.py 100.00% <100.00%> (ø)
mapie/quantile_regression.py 100.00% <100.00%> (ø)
mapie/regression.py 100.00% <100.00%> (ø)
mapie/tests/test_classification.py 100.00% <100.00%> (ø)
mapie/tests/test_common.py 100.00% <100.00%> (ø)
mapie/tests/test_conformity_scores.py 100.00% <100.00%> (ø)
mapie/tests/test_metrics.py 100.00% <100.00%> (ø)
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@vincentblot28 vincentblot28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good !

Copy link
Collaborator

@vincentblot28 vincentblot28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job !

@vincentblot28 vincentblot28 merged commit 34a61c1 into master Jan 3, 2023
@thibaultcordier thibaultcordier deleted the 245-sorting-the-libraries-using-isort branch March 3, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sorting the libraries using isort Issue with Boston dataset documentation
3 participants