-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX: Set random state in classification test #306
FIX: Set random state in classification test #306
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #306 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 32 32
Lines 3523 3524 +1
Branches 364 364
=========================================
+ Hits 3523 3524 +1
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add this change to the History.rst
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good. I think it would be best to set the variable random_state = 42
and then use that variable every time. But this fixes the quick issue.
…ithub.com/scikit-learn-contrib/MAPIE into thibaultcordier-patch-test_classification
…ithub.com/scikit-learn-contrib/MAPIE into thibaultcordier-patch-test_classification
Description
Set the random state of a classification test (this test sometimes leads to coverage failure).
Fixes #307
Type of change
Checklist
make lint
make type-check
make tests
make coverage
make doc