Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change return pred #38

Merged
merged 4 commits into from
May 6, 2021
Merged

Change return pred #38

merged 4 commits into from
May 6, 2021

Conversation

vtaquet
Copy link
Member

@vtaquet vtaquet commented May 6, 2021

Description

return_pred string argument is now a Boolean called ensemble. By default, ensemble = False returns the predictions from the unperturbed estimator.

Type of change

Please check options that are relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • I have read the contributing guidelines
  • I have updated the HISTORY.rst and AUTHORS.rst files
  • Linting passes successfully : flake8 . --exclude=doc
  • Typing passes successfully : mypy mapie examples --strict --config-file mypy.ini
  • Unit tests pass successfully : pytest -vs --doctest-modules mapie
  • Coverage is 100% : pytest -vs --doctest-modules --cov-branch --cov=mapie --pyargs mapie
  • Documentation builds successfully : cd doc; make clean; make html

@codecov
Copy link

codecov bot commented May 6, 2021

Codecov Report

Merging #38 (c804a2e) into master (6dcb5cb) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #38   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         7           
  Lines          252       251    -1     
  Branches        19        19           
=========================================
- Hits           252       251    -1     
Impacted Files Coverage Δ
mapie/estimators.py 100.00% <100.00%> (ø)
mapie/tests/test_estimators.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6dcb5cb...c804a2e. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants