Aesthetics #49
Merged
Aesthetics #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #49 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 7 7
Lines 407 409 +2
Branches 32 32
=========================================
+ Hits 407 409 +2
Continue to review full report at Codecov.
|
vtaquet
reviewed
May 27, 2021
| @@ -4,7 +4,7 @@ | |||
| - [ ] Check whether any new files need to go in MANIFEST.in | |||
| - [ ] Make sure tests run, pass and cover 100% of the package: | |||
| * `flake8 . --exclude=doc` | |||
| * `mypy mapie examples --strict --config-file mypy.ini` | |||
There was a problem hiding this comment.
Pourquoi supprimer le fichier de configuration ?
There was a problem hiding this comment.
Le fichier mypy.ini est en fait déjà lu par défaut, il n'y a pas besoin de repréciser
https://mypy.readthedocs.io/en/stable/config_file.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
np.stack. bynp.column_stackfor less verbosity and improved readabilitypredictmethodType of change
Please check options that are relevant.
How Has This Been Tested?
as usual
Checklist:
flake8 . --exclude=docmypy mapie examples --strict --config-file mypy.inipytest -vs --doctest-modules mapiepytest -vs --doctest-modules --cov-branch --cov=mapie --pyargs mapiecd doc; make clean; make html