-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update implementation of classification module + check before quantile calculation #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #84 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 11 11
Lines 897 926 +29
Branches 59 64 +5
=========================================
+ Hits 897 926 +29
Continue to review full report at Codecov.
|
vtaquet
reviewed
Aug 30, 2021
vtaquet
reviewed
Aug 30, 2021
vtaquet
reviewed
Aug 30, 2021
vtaquet
reviewed
Aug 30, 2021
vtaquet
reviewed
Aug 30, 2021
vtaquet
reviewed
Aug 30, 2021
vtaquet
reviewed
Aug 30, 2021
vtaquet
reviewed
Aug 30, 2021
vtaquet
reviewed
Aug 30, 2021
vtaquet
reviewed
Aug 30, 2021
vtaquet
reviewed
Aug 31, 2021
vtaquet
reviewed
Aug 31, 2021
vtaquet
reviewed
Aug 31, 2021
vtaquet
reviewed
Aug 31, 2021
vtaquet
reviewed
Aug 31, 2021
vtaquet
reviewed
Aug 31, 2021
vtaquet
reviewed
Aug 31, 2021
vtaquet
reviewed
Aug 31, 2021
vtaquet
reviewed
Aug 31, 2021
vtaquet
reviewed
Aug 31, 2021
vtaquet
reviewed
Aug 31, 2021
vtaquet
reviewed
Aug 31, 2021
vtaquet
reviewed
Aug 31, 2021
vtaquet
reviewed
Aug 31, 2021
vtaquet
reviewed
Aug 31, 2021
vtaquet
reviewed
Aug 31, 2021
vtaquet
reviewed
Sep 1, 2021
vtaquet
reviewed
Sep 1, 2021
vtaquet
reviewed
Sep 1, 2021
vtaquet
reviewed
Sep 1, 2021
vtaquet
reviewed
Sep 1, 2021
vtaquet
reviewed
Sep 1, 2021
vtaquet
reviewed
Sep 1, 2021
vtaquet
reviewed
Sep 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Grouping of score calculations in the fit
Changing attribute name of n_samples_in_train_ by n_samples_in_val_
Adding check if 1/alpha < number of samples of scores before quantile calculation
Fixes #(issue)
Please check options that are relevant.
How Has This Been Tested?
tests added in test_utils.py
Checklist:
flake8 . --exclude=doc
mypy mapie examples --strict
pytest -vs --doctest-modules mapie
pytest -vs --doctest-modules --cov-branch --cov=mapie --pyargs mapie
cd doc; make clean; make html