Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update implementation of classification module + check before quantile calculation #84

Merged
merged 4 commits into from
Sep 1, 2021

Conversation

aagoumbala
Copy link
Contributor

Description

Grouping of score calculations in the fit
Changing attribute name of n_samples_in_train_ by n_samples_in_val_
Adding check if 1/alpha < number of samples of scores before quantile calculation

Fixes #(issue)

Please check options that are relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

tests added in test_utils.py

Checklist:

  • I have read the contributing guidelines
  • I have updated the HISTORY.rst and AUTHORS.rst files
  • Linting passes successfully : flake8 . --exclude=doc
  • Typing passes successfully : mypy mapie examples --strict
  • Unit tests pass successfully : pytest -vs --doctest-modules mapie
  • Coverage is 100% : pytest -vs --doctest-modules --cov-branch --cov=mapie --pyargs mapie
  • Documentation builds successfully : cd doc; make clean; make html

@codecov-commenter
Copy link

codecov-commenter commented Aug 30, 2021

Codecov Report

Merging #84 (71e75a4) into dev (2241a66) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               dev       #84   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           11        11           
  Lines          897       926   +29     
  Branches        59        64    +5     
=========================================
+ Hits           897       926   +29     
Impacted Files Coverage Δ
mapie/classification.py 100.00% <100.00%> (ø)
mapie/tests/test_classification.py 100.00% <100.00%> (ø)
mapie/tests/test_utils.py 100.00% <100.00%> (ø)
mapie/utils.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2241a66...71e75a4. Read the comment docs.

@aagoumbala aagoumbala requested a review from vtaquet August 30, 2021 10:50
@vtaquet vtaquet merged commit 591ec06 into dev Sep 1, 2021
@gmartinonQM gmartinonQM deleted the update_implementation_of_classification branch September 9, 2021 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants