Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

class JackknifeAB restricted to a smaller class Resample and argument… #96

Merged
merged 8 commits into from
Oct 12, 2021

Conversation

JulienRoussel77
Copy link
Collaborator

… cv replaced by agg_functionin MapieRegressor

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #(issue)

Type of change

Please remove options that are irrelevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • I have read the contributing guidelines
  • I have updated the HISTORY.rst and AUTHORS.rst files
  • Linting passes successfully : make lint
  • Typing passes successfully : make type-check
  • Unit tests pass successfully : make tests
  • Coverage is 100% : make coverage
  • Documentation builds successfully : make doc

… cv replaced by agg_functionin MapieRegressor
@codecov-commenter
Copy link

codecov-commenter commented Sep 29, 2021

Codecov Report

Merging #96 (d79ee69) into dev (1a7fff6) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               dev       #96   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           11        13    +2     
  Lines          943       971   +28     
  Branches        73        75    +2     
=========================================
+ Hits           943       971   +28     
Impacted Files Coverage Δ
mapie/regression.py 100.00% <100.00%> (ø)
mapie/subsample.py 100.00% <100.00%> (ø)
mapie/tests/test_regression.py 100.00% <100.00%> (ø)
mapie/tests/test_subsample.py 100.00% <100.00%> (ø)
mapie/utils.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a7fff6...d79ee69. Read the comment docs.

Copy link
Collaborator Author

@JulienRoussel77 JulienRoussel77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Répondu

@JulienRoussel77 JulienRoussel77 force-pushed the reviewing_regression_jro branch 2 times, most recently from 6e1ea49 to 326b537 Compare October 4, 2021 14:56
@JulienRoussel77 JulienRoussel77 force-pushed the reviewing_regression_jro branch from 6d0dc30 to f429290 Compare October 8, 2021 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants