Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add J+aB and APS methods #99

Merged
merged 105 commits into from
Nov 16, 2021
Merged

Add J+aB and APS methods #99

merged 105 commits into from
Nov 16, 2021

Conversation

vtaquet
Copy link
Member

@vtaquet vtaquet commented Oct 12, 2021

Description

Add two methods in MAPIE :

  • Jackknife+-after-Bootstrap in MapieRegressor following Kim+2020
  • Adaptive Prediction Set in MapieClassifier following Sadinle+2020 and Angelopoulos+2021

Fixes #(issue)

Type of change

Please remove options that are irrelevant.

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Unit tests.

Checklist:

  • I have read the contributing guidelines
  • I have updated the HISTORY.rst and AUTHORS.rst files
  • Linting passes successfully : make lint
  • Typing passes successfully : make type-check
  • Unit tests pass successfully : make tests
  • Coverage is 100% : make coverage
  • Documentation builds successfully : make doc

Abdou Akim GOUMBALA and others added 30 commits September 13, 2021 11:30
MISS: trimmed mean
# Conflicts:
#	HISTORY.rst
#	mapie/regression.py
#	mapie/tests/test_regression.py
#	mapie/utils.py
Julien is gonna proofread algorithms' implementation
… cv replaced by agg_functionin MapieRegressor
…utorial

fisrt instance of the classification tutorial
Copy link
Collaborator

@gmartinonQM gmartinonQM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some typos

Copy link
Collaborator

@gmartinonQM gmartinonQM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent job ! Some details, and potentially a last simplification of add_random_tie_breaking and we are done !

Copy link
Collaborator

@gmartinonQM gmartinonQM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants