Accessed point coordinates via public attribute #171
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ValarDragon
approved these changes
Jul 7, 2020
AntoineRondelet
force-pushed
the
fix-curves-interfaces
branch
from
e89d6b3 to
fdd39a5
Compare
Good catch @ValarDragon I forgot to update the submodule after the proposed changes were merged in libff. I updated the libff submodule to point to scipr-lab/libff@5835b8c which as of today is the "tip" of the master branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes are related to scipr-lab/libff#35 and this PR should be merged after the one on libff to track the changes on the master branch of libff via the submodules