-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add poetry support #470
Add poetry support #470
Conversation
Can one of the admins verify this patch? |
2 similar comments
Can one of the admins verify this patch? |
Can one of the admins verify this patch? |
Hello. Thanks for the PR! Have you tried micropipenv? We already support it and it can install dependencies from various sources including poetry.lock files. A few notes:
I can take the PR and improve it but first of all, I'd like to know whether micropipenv works for you or not and how/why. |
Hey! I didn't know about micropipenv, it seems to be a good candidate to replace our Poetry-based hack in |
There is a new release of micropipenv with improved support for poetry. Could you please test it? |
Yes, that specific issue is fixed, thanks! Unfortunately we now hit another one: thoth-station/micropipenv#192 :-/ |
We have managed to fix all the known bugs related to poetry support in micropipenv. Do you think that it's enough to support micropipenv here and not poetry directly? |
Yeah I think it's sufficient, one of my poetry-based projects can now use micropipenv, so thanks! |
Ok! Closing pull request. |
It would be nice to have poetry support.