Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add poetry support #470

Closed
wants to merge 1 commit into from
Closed

Add poetry support #470

wants to merge 1 commit into from

Conversation

LenkaSeg
Copy link

It would be nice to have poetry support.

@centos-ci
Copy link
Collaborator

Can one of the admins verify this patch?

2 similar comments
@centos-ci
Copy link
Collaborator

Can one of the admins verify this patch?

@centos-ci
Copy link
Collaborator

Can one of the admins verify this patch?

@frenzymadness
Copy link
Member

Hello. Thanks for the PR! Have you tried micropipenv? We already support it and it can install dependencies from various sources including poetry.lock files.

A few notes:

  • Poetry will soon stop supporting Python 2 so we should implement it for Python 3 only.
  • It has to be implemented also in src/s2i/bin/assemble where the installation of the tools actually happens.
  • It would be nice to have two commits here: One with changes made to the src and examples folders and a second one with generated content from distgen.

I can take the PR and improve it but first of all, I'd like to know whether micropipenv works for you or not and how/why.

@abompard
Copy link

Hey! I didn't know about micropipenv, it seems to be a good candidate to replace our Poetry-based hack in assemble. However, we have Twisted as one of our indirect dependencies and we're hit by thoth-station/micropipenv#186, since Twisted marks some dependencies as Windows-only and micropipenv tries to install them.

@frenzymadness
Copy link
Member

There is a new release of micropipenv with improved support for poetry. Could you please test it?

@abompard
Copy link

Yes, that specific issue is fixed, thanks! Unfortunately we now hit another one: thoth-station/micropipenv#192 :-/

@frenzymadness
Copy link
Member

We have managed to fix all the known bugs related to poetry support in micropipenv. Do you think that it's enough to support micropipenv here and not poetry directly?

@abompard
Copy link

Yeah I think it's sufficient, one of my poetry-based projects can now use micropipenv, so thanks!

@LenkaSeg
Copy link
Author

Ok! Closing pull request.

@LenkaSeg LenkaSeg closed this Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants