Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a basic favicon in the various formats. #51

Closed
wants to merge 1 commit into from

Conversation

dolfs
Copy link
Contributor

@dolfs dolfs commented Mar 12, 2018

  • The image is not optimal, but it will do for now.
  • Note: favicons dot not show in Safari tabs, but do show in history

* The image is not optimal, but it will do for now.
* Note: favicons dot not show in Safari tabs, but do show in history
Copy link
Owner

@scottlamb scottlamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Dolf!

Did you draw this entirely yourself, or did you compose it from other sources? If the latter, are there licensing details we should note in some fashion? E.g., my understanding is that CC BY is a common license for image assets; I think we'd need to add something to LICENSE.

@dolfs
Copy link
Contributor Author

dolfs commented Mar 12, 2018

The image is a composition (Photoshop) of two others:

  • The moon against the ridge was taken from https://twitter.com/fire_party and does not appear to have any copyright notice with it. I consider it in the public domain
  • The camera came from a product image on Amazon (I think), so should not be a problem either.

So I think CC BY would be appropriate. If we ever have something professionally designed that might be different.

@scottlamb
Copy link
Owner

Shoot. My understanding is that images are copyrighted by default rather than in the public domain. And I wouldn't be surprised if a security camera company in particular were upset about using their image in our NVR; it could be taken as an endorsement. Sorry. We can't use either of those images.

Maybe it's better to use something more abstract/icon-like anyway; at least when used as a Chrome tab icon, you really can't make out much detail.

@scottlamb scottlamb closed this Mar 13, 2018
@scottlamb scottlamb mentioned this pull request Mar 13, 2018
@dolfs
Copy link
Contributor Author

dolfs commented Mar 13, 2018

OK, so I updated my PR branch with a CC0 based image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants