Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(feat):
read_lazy
for wholeAnnData
lazy-loading +xarray
reading +read_elem_as_dask
->read_elem_lazy
#1247base: main
Are you sure you want to change the base?
(feat):
read_lazy
for wholeAnnData
lazy-loading +xarray
reading +read_elem_as_dask
->read_elem_lazy
#1247Changes from 250 commits
ffe89f0
6cb231e
029add9
75a64fc
3f734fe
c4c2356
cc67a9b
fcb1763
adcd48a
2a72ec0
4c659a1
d3a811a
e852a74
8c92a41
47be954
55f706f
6fa97f0
9e2e21d
eb1237c
6724c62
53796a0
076b92f
036ff3f
9415a14
b5dfaac
d45a2ce
cff41c4
3ccbfaf
ff4d487
ed8fedf
e0e8891
3325f38
528026f
aa0d161
41e3038
dc5c6e6
4edd279
969c6af
2a31ab8
2521ff8
628f9fc
ff9412a
36d57be
51610b1
ba8d147
2cf1262
b1feb6f
02741f5
24e8970
ab3e718
4412710
d3401b2
ef0bbf3
3b6d194
4587fec
97eace5
58654a8
67af64f
bfc2e73
b801d35
a1d0b89
160b522
5f80b61
8ce6409
f9ef9f0
5e69a50
1540d27
371fc2b
5cb2d8d
b86ee6b
227a3c6
3debf9b
4b48988
28c95a7
cec633a
97aff04
bf710d0
1dfebde
d355ed0
cfae08a
1c46ec6
f491724
411bd91
7f89eb3
d77ba37
096f2c6
3c7c627
74b1940
04206b8
a7cbbd8
36bc262
af4520a
fa7358f
4db8c1b
eefbee6
39f2838
dcca711
d3121b7
b25e8ba
870a4f2
c2681e0
e7a915b
f93499d
63a4515
b1c8c22
d082a35
e81d155
c8c5271
c4d0146
b34ac0a
1f4ab92
d25f559
c661d39
bff63cb
784ea9b
9b2d9a3
489cc8d
24f11be
57bcfd9
8b07f43
408d62a
cb125bf
e14f53f
3c5641c
dbe09ca
67fc546
41a9335
58e595b
8875374
4c991d4
50cdc66
eb881a9
fe1f0a6
c0c0c6c
fc72011
562817d
9ef7cf5
69b6cc1
3dfefc4
1eb440e
fe77a5c
a654421
015bdca
7201bad
5d813c0
b50e8ad
3ca669c
7ea20df
91fdb90
a71dad8
0ac61c6
af5c2fe
edac279
cdd9b89
e07426a
8278e0f
30d1bb1
509af7f
58122a1
e6fea74
bd509a1
62cda13
4e1a1f6
a242dea
07caf93
8fd1fa0
94cf8ea
f01818a
aca24db
2c082bf
81c5fb9
bb49dd2
942661f
99219c6
98197fe
752e02b
2a38900
cc40369
a807673
852ab20
310191c
1c15b70
b96bd55
a663c5d
d1fce7e
52b6a01
a796d9b
be786d0
e48377a
90f6d77
8e29713
f13bfb4
1643da6
5013823
4c00216
8b95aff
dee82a2
843cae8
fa41e35
1ab575c
0c777ef
fc13a2f
bfa5fc9
0b93086
a045853
c9253a9
8b2e208
edbd7bc
207a89c
7166a3c
61babe8
b643d9a
6db4255
42baa7a
3adde1a
e225caa
021d8f9
aa62f5f
df2e518
802fafb
f314da7
7769f85
93ef3f1
00cc32d
aa79243
b304edc
7d03d36
9f143e5
6f149df
b07d225
908cb98
1cece74
ff928cf
d14ffa9
3733dba
c58f0cc
19973b0
d7435c0
5317718
ac144f9
7728063
29b5914
b8080f9
99acfc5
1b9fab3
4e6bb60
f25afa1
b46ae71
f0c182d
51021dd
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe a different name? Not sure about
test-full
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what to do about optional deps here....I think
fsspec
should be added as well to make it feature complete, or we should remove all of them exceptxarray
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why requests though?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is needed for "remote" data with
zarr<3
so I figured I'd throw it in. Same thing withaiohttp
. Both could be removed but that would produce an error immediately upon people usingzarr
v2 with this and remote data.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note this comment. This line was causing problems with the
load_annotation_index=True
case, if I remember. But all tests pass without thisThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
assert
s don’t necessary exist in runtime code (can be optimized out). So if whoever wrote them knows what they’re doing, asserts in runtime code are purely there to make debugging easier in case the asserts fail.Ruff has a check to disallow
assert
s, we should probably activate it for non-test code and replace them withraise AssertionError(msg)
(which isn’t optimized out)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But it would be good to understand what we even going on here @ivirshup ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean if the tests pass, we're good? And if we're not good, we should add a test?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, so it’s not possible that
_normalize_index
ever gets called with the wrong type of index as result of user action?If that’s impossible, feel free to remove. Otherwise we should probably update this check to a TypeError or so.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated!
Check warning on line 121 in src/anndata/_core/index.py
src/anndata/_core/index.py#L121