-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add annsel #227
Add annsel #227
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me other than the comment, but not sure about that
packages/annsel/meta.yaml
Outdated
- accessor | ||
- utilities | ||
test_command: | | ||
uv pip install .[test] && uv run pytest -n auto |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@grst This won't work out-of-the-box since there is no env created - how do we handle this command? By contrast, pip install xxxx
will work because you don't need a virtual env for that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
uv run pytest
should work without pip install?
This test command is anyway more to prove there are tests, as we don't execute it (for now).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
uv pip install
won't work though, no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@srivarra so perhaps just use pip
here for now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ilan-gold Just replaced it with only pip
!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pip install xxxx
will work because you don't need a virtual env for that
not on modern systems:
$ pip install httpx
error: externally-managed-environment
× This environment is externally managed
╰─> To install Python packages system-wide, try 'pacman -S
python-xyz', where xyz is the package you are trying to
install.
If you wish to install a non-Arch-packaged Python package,
create a virtual environment using 'python -m venv path/to/venv'.
Then use path/to/venv/bin/python and path/to/venv/bin/pip.
If you wish to install a non-Arch packaged Python application,
it may be easiest to use 'pipx install xyz', which will manage a
virtual environment for you. Make sure you have python-pipx
installed via pacman.
note: If you believe this is a mistake, please contact your Python installation or OS distribution provider. You can override this, at the risk of breaking your Python installation or OS, by passing --break-system-packages.
hint: See PEP 668 for the detailed specification.
But hatch test
(or uvx hatch test
or pipx hatch test
) will work if the respective tools are installed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but it should work in a CI context with sudo rights?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably, yeah. uv pip install --system
too.
(sorry @srivarra for using your PR as a discussion platform for this, but we should probably improve our guidance on what the test command should be)
Thanks @srivarra! |
Checklist for adding packages
Mandatory
Name of the tool: annsel
Short description: Annsel is a user-friendly library that brings familiar dataframe-style operations to AnnData objects such as filter, select, and group by's.
How does the package use scverse data structures (please describe in a few sentences):
It uses AnnData's
obs
,var
,X
,obs_names
. andvar_names
attributes to filter, select and run "group bys" in order to partition and subset the AnnData object as a whole. For example, a user can filter their AnnData object based on a "Cell Type" column inobs
.Recommended
Zulip link
@scverse_team
) to include are: