Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ete3 warning masks other ImportErrors #207

Closed
Moomboh opened this issue Feb 23, 2023 · 0 comments · Fixed by #208
Closed

ete3 warning masks other ImportErrors #207

Moomboh opened this issue Feb 23, 2023 · 0 comments · Fixed by #208
Labels
bug Something isn't working

Comments

@Moomboh
Copy link
Contributor

Moomboh commented Feb 23, 2023

Describe the bug

To Reproduce

Steps to reproduce the behavior:

  1. Install pyqt5, ete3 and pertpy
  2. Assert import ete3 works fine
  3. import pertpy as pt -> shows warning for ete3

Actual behaviour
Warning appears:

To use sccoda or tasccoda please install ete3 with `pip install ete3`

Expected behavior
No warning when ete3 available.

System [please complete the following information]:

  • OS: macOS 13.1, Apple M1 Max
  • Language Version: Python 3.9
  • Virtual environment: micromamba with:
    # environment.yaml
    name: pertpy-apple-silicon
    channels:
      - conda-forge
    dependencies:
      - python=3.9
      - rpy2
    brew install qt5
    # make sure to add all the environment variables to your .zshrc
    # as described at the end of the output of the brew install command
    # then reload your shell:
    zsh
    create environment with mamba (conda should work as well, but I haven't tested it)
    mamba create -f environment.yaml -n pertpy-apple-silicon
    mamba activate pertpy-apple-silicon
    pip install pyqt5 --config-settings --confirm-license= --verbose
    pip install ete3
    pip install git+https://github.com/theislab/pertpy.git

Additional context

Bug in pertpy/tools/init.py#L10
There are faulty import paths getting masked by the catching of the ImportError for the ete3 warning.
from pertpy.tools.coda._sccoda import Sccoda works fine.

Follow up on #201

@Moomboh Moomboh added the bug Something isn't working label Feb 23, 2023
@Moomboh Moomboh changed the title ete3 ete3 warning masks other ImportErrors Feb 23, 2023
Moomboh added a commit to Moomboh/pertpy that referenced this issue Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant