scCODA: add low/high acceptance probability warnings #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
|
Great! I'll merge this later. Test failures are unrelated and/or my fault. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
docsis updatedDescription of changes
Technical details
Sometimes, the MCMC samplers in scCODA/tascCODA do not converge or converge to the wrong local minimum. This is usually due to bad initialization values and can be fixed by re-running with a different rng key.
An unusually low or high acceptance rate is a good indicator for a misspecified sampler, but there are no strict bounds for good acceptance rates. Therefore, we can only display a message and ask users to check whether results are feasible
Additional context
In response to #359.