Fixed set_fdr for tascCODA models #411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
Zethson
approved these changes
Oct 24, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #411 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 40 40
Lines 4882 4887 +5
=====================================
- Misses 4882 4887 +5
|
Co-authored-by: Lukas Heumos <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Description of changes
Fix of the
set_fdrmethod for tree_agg models (tascCODA models). Since thesummary_preparemethod returns three values for tree_agg models but the previous code inset_fdraccepted only two (which is correct in the case of a classical model), an error was thrown. This bug is easily fixed by differentiating between the two models and then either expect thesummary_preparemethod to return two or three values.