Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cinemaot dataset loader #424

Merged
merged 7 commits into from
Nov 17, 2023
Merged

Cinemaot dataset loader #424

merged 7 commits into from
Nov 17, 2023

Conversation

Lilly-May
Copy link
Collaborator

@Lilly-May Lilly-May commented Nov 8, 2023

PR Checklist

Description of changes

I have added the full cinemaot dataset (9209 cells). Previously, only a subsampled version was available through pt.dt.cinemaot_example(). However, to provide an example for the cinemaot.synergy() method, we need the full dataset because it contains cells with all three stimulations, while the subsampled version contains only one stimulation.

The subsampled dataset is still available via pt.dt.cinemaot_example(), the full dataset can now be obtained using pt.dt.cinemaot_full().

@Lilly-May Lilly-May requested a review from Zethson November 8, 2023 08:51
Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Merging #424 (ca5e744) into main (afffb9a) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #424   +/-   ##
=======================================
  Coverage   58.23%   58.23%           
=======================================
  Files          40       40           
  Lines        4899     4899           
=======================================
  Hits         2853     2853           
  Misses       2046     2046           
Files Coverage Δ
pertpy/data/__init__.py 100.00% <ø> (ø)
pertpy/data/_datasets.py 100.00% <ø> (ø)
pertpy/tools/_cinemaot.py 57.14% <ø> (ø)

Copy link
Member

@Zethson Zethson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@Zethson
Copy link
Member

Zethson commented Nov 12, 2023

On a second thought we should rename it to dong_2023 instead of cinemaot_full?

@Lilly-May Lilly-May merged commit e17ade7 into main Nov 17, 2023
@Lilly-May Lilly-May deleted the cinemaot_dataset_loader branch November 17, 2023 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants