Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Augur bug #533

Merged
merged 4 commits into from
Feb 10, 2024
Merged

Fixed Augur bug #533

merged 4 commits into from
Feb 10, 2024

Conversation

namsaraeva
Copy link
Collaborator

No description provided.

@namsaraeva namsaraeva linked an issue Feb 10, 2024 that may be closed by this pull request
@github-actions github-actions bot added the bug Something isn't working label Feb 10, 2024
@@ -877,6 +877,9 @@ def predict_differential_prioritization(
& set(permuted_results1["summary_metrics"].columns)
& set(permuted_results2["summary_metrics"].columns)
)

cell_types = list(cell_types)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the initial bug: TypeError: Passing a set as an indexer is not supported. Use a list instead.

@namsaraeva namsaraeva requested a review from Zethson February 10, 2024 14:40
@namsaraeva namsaraeva self-assigned this Feb 10, 2024
Copy link
Member

@Zethson Zethson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful

@Zethson Zethson merged commit 8f2df26 into main Feb 10, 2024
3 of 7 checks passed
@namsaraeva namsaraeva deleted the augur_error branch February 19, 2024 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Augur example code throws a TypeError
2 participants