enhancement: add fresh, max/min count by columns #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Regarding testing: you should be able to import the overridden test library in your workspace.sdf.yml file. Then it will prioritize/use your version over the one included with the SDF binary. Could you please try this before landing? Note: the CI test failed because of a syntax error. |
|
Will iterate
Thanks,
Daniel
…________________________________
From: milevin ***@***.***>
Sent: Saturday, October 5, 2024 1:54:32 AM
To: sdf-labs/tests ***@***.***>
Cc: Daniel Bartley ***@***.***>; Author ***@***.***>
Subject: Re: [sdf-labs/tests] enhancement: add fresh, max/min count by columns (PR #7)
Regarding testing: you should be able to import the overridden test library in your workspace.sdf.yml file. Then it will prioritize/use your version over the one included with the SDF binary.
Could you please try this before landing?
—
Reply to this email directly, view it on GitHub<#7 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ADLXPTJC724XYNFP6SW5WOLZZ223RAVCNFSM6AAAAABPKXQFK2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOJUGAYDQNRTGE>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
Will reopen this after we uplift the testing of changes to tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How do we test the macros?
Is it ok if I alphabetize the test list in the readme?