Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: base image for arm #7

Merged
merged 1 commit into from
Sep 5, 2023
Merged

fix: base image for arm #7

merged 1 commit into from
Sep 5, 2023

Conversation

supermaxiste
Copy link
Member

After trying to run the Docker image on my Mac I realized I confused the name of the base image for arm.
amd64 is an x86 base image. I now found an arm64 base image from amazoncorretto with which I was able to build and run the image locally 👍

@supermaxiste supermaxiste added the bug Something isn't working label Sep 5, 2023
@supermaxiste supermaxiste requested a review from cmdoret September 5, 2023 08:34
@supermaxiste supermaxiste self-assigned this Sep 5, 2023
cmdoret
cmdoret approved these changes Sep 5, 2023
View reviewed changes
Copy link
Member

@cmdoret cmdoret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@supermaxiste supermaxiste merged commit 4602c17 into master Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmdoret cmdoret cmdoret approved these changes

Assignees

@supermaxiste supermaxiste

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@supermaxiste @cmdoret