Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: multiarch Github action to have both x86 and arm64 images #8

Merged
merged 1 commit into from
Sep 22, 2023

Conversation

supermaxiste
Copy link
Member

Our good old @rmfranken spotted a bug in the validation GH action causing the following error:

Unable to find image 'ghcr.io/sdsc-ord/shacl:latest' locally
latest: Pulling from sdsc-ord/shacl
docker: no matching manifest for linux/amd64 in the manifest list entries.

It looks like our current setup does not provide images for both arm and x86, instead the GitHub action overwrites the x86 image with the arm one, which is the only one available. After a bit of search I found out the correct approach to build multiarch images when we have different arguments involved: matrix!
This PR implements the matrix approach to allow proper multiarch images for shacl.

@supermaxiste supermaxiste added the bug Something isn't working label Sep 21, 2023
@supermaxiste supermaxiste self-assigned this Sep 21, 2023
Copy link
Member

@cmdoret cmdoret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! This is much cleaner 👍

@rmfranken
Copy link
Member

Hahah, you give me too much credit. Spotting this bug is like saying: The car isn't working, and getting the credit for the diagnosis that it was the leaky fuel pump. Thank you for finding the leaky fuel pump @supermaxiste .

@supermaxiste supermaxiste merged commit 433757c into master Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants