Update tfms #107
Merged
Update tfms #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lahma
reviewed
May 18, 2024
src/Parlot/Parlot.csproj
Outdated
| @@ -14,16 +14,9 @@ | |||
| </PropertyGroup> | |||
|
|
|||
| <ItemGroup> | |||
| <PackageReference Include="System.Memory" Condition="'$(TargetFramework)' == 'netstandard2.0'" /> | |||
| <PackageReference Include="System.Collections.Immutable" Condition="'$(TargetFramework)' == 'netstandard2.0' or '$(TargetFramework)' == 'netstandard2.1'" /> | |||
| <PackageReference Include="System.Memory" Condition="'$(TargetFramework)' == 'net462' "/> | |||
There was a problem hiding this comment.
Suggested change
| <PackageReference Include="System.Memory" Condition="'$(TargetFramework)' == 'net462' "/> | |
| <PackageReference Include="System.Memory" Condition="!$([MSBuild]::IsTargetFrameworkCompatible('$(TargetFramework)', 'net6.0'))" /> |
src/Parlot/Parlot.csproj
Outdated
| <PackageReference Include="System.Memory" Condition="'$(TargetFramework)' == 'netstandard2.0'" /> | ||
| <PackageReference Include="System.Collections.Immutable" Condition="'$(TargetFramework)' == 'netstandard2.0' or '$(TargetFramework)' == 'netstandard2.1'" /> | ||
| <PackageReference Include="System.Memory" Condition="'$(TargetFramework)' == 'net462' "/> | ||
| <PackageReference Include="System.Collections.Immutable" Condition="'$(TargetFramework)' == 'net462' or '$(TargetFramework)' == 'net6.0'" /> |
There was a problem hiding this comment.
Suggested change
| <PackageReference Include="System.Collections.Immutable" Condition="'$(TargetFramework)' == 'net462' or '$(TargetFramework)' == 'net6.0'" /> | |
| <PackageReference Include="System.Collections.Immutable" Condition="!$([MSBuild]::IsTargetFrameworkCompatible('$(TargetFramework)', 'net6.0'))" /> |
| @@ -1,3 +1,3 @@ | |||
| #if !NET8_0_OR_GREATER | |||
There was a problem hiding this comment.
This should be always "on" with pre-compiler directives.
should add to csproj:
<PackageReference Include="PolySharp" Version="1.14.1" PrivateAssets="all" />
then remove files IsExternalInit.cs and SkiptLocalsInitAttribute.cs
| <PackageReference Include="System.Memory" Condition="'$(TargetFramework)' == 'netstandard2.0'" /> | ||
| <PackageReference Include="System.Collections.Immutable" Condition="'$(TargetFramework)' == 'netstandard2.0' or '$(TargetFramework)' == 'netstandard2.1'" /> | ||
| <PackageReference Include="System.Memory" Condition="'$(TargetFramework)' == 'net462' "/> | ||
| <PackageReference Include="System.Collections.Immutable" Condition="'$(TargetFramework)' == 'net462' or '$(TargetFramework)' == 'net6.0'" /> | ||
| <PackageReference Include="FastExpressionCompiler.Internal.src" PrivateAssets="all" /> |
There was a problem hiding this comment.
Suggested change
| <PackageReference Include="FastExpressionCompiler.Internal.src" PrivateAssets="all" /> | |
| <PackageReference Include="FastExpressionCompiler.Internal.src" PrivateAssets="all" /> | |
| <PackageReference Include="PolySharp" Version="1.14.1" PrivateAssets="all" /> |
|
Thanks for the feedback Marko |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realized the net8.0 was not correctly setting the feature flags and was not optimized :/
Then thought I could just remove netstandard and add the specific ones since when using netstandard you still need to add an core one (recommendation).
I will definitely change my mind, but for now this is what it is.