Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement AnyOf using SearchValues #164

Merged
merged 6 commits into from
Nov 22, 2024
Merged

Implement AnyOf using SearchValues #164

merged 6 commits into from
Nov 22, 2024

Conversation

sebastienros
Copy link
Owner

Fixes #137

@sebastienros
Copy link
Owner Author

I updated the benchmarks locally to compare to Regex, and it was as fast as the compiled regex version. And AnyOf doesn't have the compiled version yet.

@sebastienros sebastienros mentioned this pull request Nov 19, 2024
Open
@sebastienros
Copy link
Owner Author

@lahma your thoughts before I merge, but more about FYI because I find it interesting. I will probably make a benchmark to compare the source generated char map and specific SearchValues instances but not yet so feel free to beat me to it.

lahma
lahma reviewed Nov 22, 2024
View reviewed changes
Copy link
Collaborator

@lahma lahma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not much to add, I haven't played with SearchValues that much yet. Could SearchValuesLiteral be internal (haven't tried to compile the API).

@sebastienros sebastienros enabled auto-merge (squash) November 22, 2024 21:40
@sebastienros sebastienros merged commit 3b195b6 into main Nov 22, 2024
1 check passed
@sebastienros sebastienros deleted the sebros/anyof branch November 22, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lahma lahma lahma left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AnyOfParser
2 participants
@sebastienros @lahma