Make cardUniqueReference nullable on transaction response

sebdesign · Dec 30, 2022 · 2a2caee · 2a2caee
1 parent 7b40deb
commit 2a2caee
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,6 +5,12 @@ All notable changes to `sebdesign/laravel-viva-payments` will be documented in t
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [6.0.0-alpha.6] - 2022-12-30
+
+### Fixed
+
+-   Make `cardUniqueReference` nullable on transaction response ([#29](https://github.com/sebdesign/laravel-viva-payments/issues/29))
+
 ## [6.0.0-alpha.5] - 2022-11-30
 
 ### Fixed

diff --git a/phpstan.neon.dist b/phpstan.neon.dist
@@ -17,7 +17,7 @@ parameters:
         RecurringTransactionArray: 'array{Emv:?string, Amount:float, StatusId:string, RedirectUrl:?string, CurrencyCode:string, TransactionId:string, TransactionTypeId:int, ReferenceNumber:int, IssuerMessage:?string, AuthorizationId:string, IssuerMessageControl:mixed, Ctap:mixed, RetrievalReferenceNumber:string, Loyalty:?string, CartesBancaires:?string, ThreeDSecureStatusId:int, ErrorCode:int, ErrorText:?string, TimeStamp:string, CorrelationId:?string, EventId:int, Success:bool}'
         TransactionFailedArray: 'array{Moto:bool, Email:string, Phone:string, BankId:string, Systemic:bool, Switching:bool, ParentId:?string, Amount:float, ChannelId:string, TerminalId:int, MerchantId:string, OrderCode:string, ProductId:?string, StatusId:string, FullName:string, ResellerId:?string, InsDate:string, TotalFee:float, CardUniqueReference:string, CardToken:string, CardNumber:string, TipAmount:float, SourceCode:string, SourceName:string, Latitude:?float, Longitude:?float, CompanyName:String, TransactionId:string, CompanyTitle:string, PanEntryMode:string, ReferenceNumber:int, ResponseCode:?string, CurrencyCode:string, OrderCulture:string, MerchantTrns:?string, CustomerTrns:string, IsManualRefund:bool, TargetPersonId:?string, TargetWalletId:?string, LoyaltyTriggered:bool, TransactionTypeId:int, TotalInstallments:int, CardCountryCode:?string, CardIssuingBank:?string, RedeemedAmount:int, ClearanceDate:?int, CurrentInstallment:?int, Tags:string[], BillId:?string, ResellerSourceCode:?string, ResellerSourceName:?string, ResellerCompanyName:?string, ResellerSourceAddress:?string, CardExpirationDate:string, RetrievalReferenceNumber:?string, AssignedMerchantUsers:string[], AssignedResellerUsers:string[], CardTypeId:int, DigitalWalletId:?int, ResponseEventId:?string, ElectronicCommerceIndicator:?string}'
         TransactionPaymentCreatedArray: 'array{Moto:bool, Email:string, Phone:string, BankId:string, Systemic:bool, Switching:bool, ParentId:?string, Amount:float, ChannelId:string, TerminalId:int, MerchantId:string, OrderCode:string, ProductId:?string, StatusId:string, FullName:string, ResellerId:?string, InsDate:string, TotalFee:float, CardUniqueReference:string, CardToken:string, CardNumber:string, TipAmount:float, SourceCode:string, SourceName:string, Latitude:?float, Longitude:?float, CompanyName:String, TransactionId:string, CompanyTitle:string, PanEntryMode:string, ReferenceNumber:int, ResponseCode:?string, CurrencyCode:string, OrderCulture:string, MerchantTrns:?string, CustomerTrns:string, IsManualRefund:bool, TargetPersonId:?string, TargetWalletId:?string, LoyaltyTriggered:bool, TransactionTypeId:int, TotalInstallments:int, CardCountryCode:?string, CardIssuingBank:?string, RedeemedAmount:int, ClearanceDate:?int, CurrentInstallment:?int, Tags:string[], BillId:?string, ResellerSourceCode:?string, ResellerSourceName:?string, ResellerCompanyName:?string, ResellerSourceAddress:?string, CardExpirationDate:string, RetrievalReferenceNumber:?string, AssignedMerchantUsers:string[], AssignedResellerUsers:string[], CardTypeId:int, DigitalWalletId:?int, ResponseEventId:?string, ElectronicCommerceIndicator:?string}'
-        TransactionArray: 'array{email:string, amount:int, orderCode:string, statusId:string, fullName:string, insDate:string, cardNumber:string, currencyCode:string, customerTrns:string, merchantTrns:?string, transactionTypeId:int, recurringSupport:bool, totalInstallments:int, cardCountryCode:?string, cardIssuingBank:?string, currentInstallment:int, cardUniqueReference:string, cardTypeId:int, digitalWalletId:?int}'
+        TransactionArray: 'array{email:string, amount:int, orderCode:string, statusId:string, fullName:string, insDate:string, cardNumber:string, currencyCode:string, customerTrns:string, merchantTrns:?string, transactionTypeId:int, recurringSupport:bool, totalInstallments:int, cardCountryCode:?string, cardIssuingBank:?string, currentInstallment:int, cardUniqueReference:?string, cardTypeId:int, digitalWalletId:?int}'
         WebhookEventDataArray: 'TransactionPaymentCreatedArray|TransactionFailedArray|array<string,mixed>'
         WebhookEventArray: 'array{Url:string, EventData:WebhookEventDataArray, Created:string, CorrelationId:string, EventTypeId:int, Delay:?string, MessageId:string, RecipientId:string, MessageTypeId:int}'
 

diff --git a/src/Responses/Transaction.php b/src/Responses/Transaction.php
@@ -24,7 +24,7 @@ public function __construct(
         public readonly ?string $cardCountryCode,
         public readonly ?string $cardIssuingBank,
         public readonly int $currentInstallment,
-        public readonly string $cardUniqueReference,
+        public readonly ?string $cardUniqueReference,
         public readonly int $cardTypeId,
         public readonly ?int $digitalWalletId = null,
     ) {