Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: ➕ enable properties extraction from Excel files #1081

Merged
merged 6 commits into from
Feb 24, 2025

Conversation

signekb
Copy link
Member

@signekb signekb commented Feb 24, 2025

Description

This adds support for excel files (in particular .xls and xlsx files).

Related to #1027

This PR needs an in-depth review.

Checklist

  • Added or updated tests
  • Ran just run-all

@signekb signekb changed the title Feat/extract resource properties from excel files feat: ✨ extract resource properties from excel files Feb 24, 2025
@signekb signekb marked this pull request as ready for review February 24, 2025 12:05
@signekb signekb requested a review from a team as a code owner February 24, 2025 12:05
@signekb signekb changed the title feat: ✨ extract resource properties from excel files feat: ✨ extract resource properties from excel files (.xlsx and .xls) Feb 24, 2025
@lwjohnst86
Copy link
Member

Wait, how is this feat? Wouldn't it be build since you haven't added any new code aside from tests.

@signekb signekb changed the title feat: ✨ extract resource properties from excel files (.xlsx and .xls) build: ✨ extract resource properties from excel files (.xlsx and .xls) Feb 24, 2025
@lwjohnst86 lwjohnst86 changed the title build: ✨ extract resource properties from excel files (.xlsx and .xls) build: ✨ enable Excel properties extraction (.xlsx and .xls) Feb 24, 2025
@lwjohnst86 lwjohnst86 changed the title build: ✨ enable Excel properties extraction (.xlsx and .xls) build: ➕ enable properties extraction from Excel Feb 24, 2025
@signekb signekb changed the title build: ➕ enable properties extraction from Excel build: ➕ enable properties extraction from Excel files Feb 24, 2025
Copy link
Member

@lwjohnst86 lwjohnst86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is fine with me! 😁 🎉 🌮

@lwjohnst86 lwjohnst86 merged commit e01bbaa into main Feb 24, 2025
3 checks passed
@lwjohnst86 lwjohnst86 deleted the feat/extract-resource-properties-from-excel-files branch February 24, 2025 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants