Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: upgrade deepmerge to resolve webpack import issue #1039

Merged
merged 1 commit into from
Feb 12, 2020
Merged

fix: upgrade deepmerge to resolve webpack import issue #1039

merged 1 commit into from
Feb 12, 2020

Conversation

childish-sambino
Copy link
Contributor

@childish-sambino childish-sambino commented Feb 10, 2020 •
edited
Loading

Fixes #899
Fixes #867

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Feb 10, 2020
@childish-sambino childish-sambino mentioned this pull request Feb 11, 2020
Closed
@childish-sambino childish-sambino merged commit 4cfbba4 into master Feb 12, 2020
@thinkingserious
Copy link
Contributor

Hello @childish-sambino,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

@childish-sambino childish-sambino deleted the deepmerge branch February 12, 2020 19:02
@commit-lint commit-lint bot mentioned this pull request Feb 12, 2020
Merged
@pawelgrzybek
Copy link

Thanks for this change. Works like a charm for me and no more webpack aliases 👌

@childish-sambino childish-sambino mentioned this pull request Mar 3, 2020
Closed
@snyk-bot snyk-bot mentioned this pull request Mar 19, 2020
Merged
@snyk-bot snyk-bot mentioned this pull request Apr 2, 2020
Merged
This was referenced Apr 17, 2020
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thinkingserious thinkingserious thinkingserious approved these changes

Assignees
No one assigned
Labels
status: code review request requesting a community code review or review from Twilio
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

deepmerge needs to be updated to latest version to prevent webpack bug deepMergeDynamicTemplateData
3 participants
@childish-sambino @thinkingserious @pawelgrzybek