Convert remix-utils to regex on serverDependenciesToBundle #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While attempting to upgrade Remix Utils to the latest version, I encountered the following error:
Diving deeper I realized that the error was due to my oversight. I had overlooked the warning to add each individual utility to the serverDependenciesToBundle configuration. Subsequently, I also noticed that a related pull request (PR) had been merged into Remix version 2.0.1 but had not completely resolved the issue.
By adding
/^remix-utils.*/,in lieu of"remix-utils"and every individual util toserverDependenciesToBundle, it stops showing the error.