Rust 1.17.0 #41
Rust 1.17.0 #41
Conversation
Firefox has raised their minimum-required version, so we can allow newer language features now.
Now that our minimum is 1.17 we can simplify some initizers.
Rust 1.17.0 and later will infer this for us.
|
@bors-servo r+ |
|
📌 Commit 5256549 has been approved by |
Rust 1.17.0 Firefox bumped their minimum so workarounds can be dropped. https://bugzilla.mozilla.org/show_bug.cgi?id=1374807 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/unicode-bidi/41) <!-- Reviewable:end -->
|
☀️ Test successful - status-travis |
|
Since this crate has a lot of downstream users besides Firefox, we should document some expectations about when it can break for users of older Rust toolchains. One option is to treat changes like this as a semver-breaking change, so that a minor update will never break an existing build. Another option is to document a support policy like "current stable release and previous 2 stable releases." |
|
Gecko will probably move closer to requiring current stable or previous stable, but documenting that requirement is a good idea. |
|
I think the idea is that "minimum rustc/rust-lang version required" is a package matter, and should be defined somewhere in the package metadata, versus the implicit annotation in Here's the Cargo discussion: rust-lang/cargo#2751 |
|
My point is that we should consider consumers besides Gecko, too. |
|
Sorry, I didn't mean to say Gecko was the only driver. Of course crates should consider the needs of everyone who depends on them. I just wanted to say we're planning to update Gecko's minimum more frequently, so that doesn't have the a limiting factor. |
|
(I'm new to Rust-Gecko and related projects, so it may be obvious, so asking anyway.) Based on this fact that Gecko is not the only driver, I assume these libraries can move at their own pace and only increase the minimum-rustc-version as needed. Then, if so, was there any need for this diff in the Rust-Gecko build process? |
|
No, this was just a cleanup. It removed code that was previously necessary to support the version of Rust used in Gecko. |
Firefox bumped their minimum so workarounds can be dropped.
https://bugzilla.mozilla.org/show_bug.cgi?id=1374807
This change is