Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Rust Under the Hood #78

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Adds Rust Under the Hood #78

wants to merge 2 commits into from

Conversation

eventhelix
Copy link

@eventhelix eventhelix commented Jul 27, 2024

We have added a description for the book Rust Under the Hood. We are the authors of the book.

Please accept this pull request.

Deepa Ahluwalia/Sandeep Ahluwalia

Copy link

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It hasn't been disclosed by the PR author (which I think is irresponsible and unacceptable) but they are the author of this particular book or closely associated with the author of this book.

The co-authors listed on the Amazon page in the link are Sandeep Ahluwalia and Deepa Ahluwalia.

Deepa Ahluwalia has a LinkedIn profile (https://www.linkedin.com/in/deepaahluwalia) which identifies them as President at EventHelix.com Inc.

The GitHub account which created this PR is associated with EventHelix.com Inc.

@eventhelix
Copy link
Author

eventhelix commented Jul 28, 2024

We're sorry if that wasn't clear. We had submitted it from an account named eventhelix.

It was never our intention to hide anything. We did not know that we had to disclose this information. We followed the instructions mentioned in the contributing page:

https://github.com/sger/RustBooks/blob/main/CONTRIBUTING.md

We will update this information in the PR description.

@dtolnay
Copy link

dtolnay commented Jul 28, 2024

No worries. I think I would just ask @sger to consider what the role of the nonfree section of this repo is, as compared against https://www.amazon.com/s?k=rust+programming&rh=n%3A5 (Amazon search for "rust programming" in the category "Books » Computers & Technology"). Not 100% of the 500 hits have Rust as the primary topic, but I would estimate at least 200 different books there would classify as foremost a Rust book.

Amazon's value proposition for discovering Rust books includes keyword search ("rust async book"), ratings, reviews, etc.

For this repo, some level of unaffiliated personal endorsement (#57) or other community engagement (#56) would make a good bar for nonfree materials, I think. Rather than being a less-complete Amazon search.

@eventhelix
Copy link
Author

We agree with you. Some unaffiliated community members should endorse the books before they get included in the list.

Thanks for your feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants