fix(hooks): useIsMobile hook should be consistent with CSS media query behavior #6652
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6123
Using the
matches
boolean on the media query change event produces better behavior at breakpoint boundaries, because for examplewindow.innerWidth
includes the scrollbar width, and comparing this does not always behave exactly like a CSS media query. There may also be the possibility of a race conditions due to a re-layout when checking window.innerWidth itself: https://gist.github.com/paulirish/5d52fb081b3570c81e3a