-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
video_core: Various small improvements and bug fixes #2525
Conversation
raphaelthegreat
commented
Feb 24, 2025
•
edited
Loading
edited
- Adds another case of missing shared memory barriers which fixes more LDS artifacts
- Improves texture cache overlap resolution to allow copying individual slices in a multi-layer mip-mapped image (credit to poly for testing and brainstorming)
- Fixes a crash when CE task finishes execution earlier than GFX task.
- Fixes crashes when emitting Quad/Rect tess shaders with default attributes
Fixes some crashes
* Better than outright crash
Also breaks CUSA28193 loading into open world areas with this assert:
|
This assert should probably be removed, as the function should be allowed to return mip 0. I can imagine this happening in cases where individual slice of first mip is accessed, so it takes right overlap path |
Yes seems fine when removed. |
For this, I can see the same sort of effect as well in CUSA16404 on characters. |
This probably has something to do with the new overlap handling commit |
The old code assumed the mip only had 1 layer thus a right overlap could not return mip 0. But with the new path we handle images that are both mip-mapped and multi-layer, thus this can happen
@Missake212 The bug should be fixed now |
No longer seeing any of reported issues so far. |