Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

video_core: Various small improvements and bug fixes #2525

Merged
merged 13 commits into from
Feb 24, 2025

Conversation

raphaelthegreat
Copy link
Collaborator

@raphaelthegreat raphaelthegreat commented Feb 24, 2025

  • Adds another case of missing shared memory barriers which fixes more LDS artifacts
  • Improves texture cache overlap resolution to allow copying individual slices in a multi-layer mip-mapped image (credit to poly for testing and brainstorming)
  • Fixes a crash when CE task finishes execution earlier than GFX task.
  • Fixes crashes when emitting Quad/Rect tess shaders with default attributes

@Missake212
Copy link
Contributor

This breaks Bloodborne

image

@squidbus
Copy link
Collaborator

Also breaks CUSA28193 loading into open world areas with this assert:

@raphaelthegreat
Copy link
Collaborator Author

raphaelthegreat commented Feb 24, 2025

Also breaks CUSA28193 loading into open world areas with this assert:

This assert should probably be removed, as the function should be allowed to return mip 0. I can imagine this happening in cases where individual slice of first mip is accessed, so it takes right overlap path

@squidbus
Copy link
Collaborator

This assert should probably be removed, as the function should be allowed to return mip 0. I can imagine this happening in cases where individual slice of first mip is accessed, so it takes right overlap path

Yes seems fine when removed.

@squidbus
Copy link
Collaborator

This breaks Bloodborne

For this, I can see the same sort of effect as well in CUSA16404 on characters.

@raphaelthegreat
Copy link
Collaborator Author

This probably has something to do with the new overlap handling commit

raphaelthegreat and others added 3 commits February 24, 2025 13:24
The old code assumed the mip only had 1 layer thus a right overlap could not return mip 0. But with the new path we handle images that are both mip-mapped and multi-layer, thus this can happen
@raphaelthegreat
Copy link
Collaborator Author

@Missake212 The bug should be fixed now

@squidbus
Copy link
Collaborator

No longer seeing any of reported issues so far.

@georgemoralis georgemoralis merged commit 76b4da6 into main Feb 24, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants