-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update MermaidJS to v10.8.0 #350
chore: update MermaidJS to v10.8.0 #350
Conversation
- chore: updates MermaidJS - chore: updates yarn.lock to fix expired certificates - doc: update Mermaid Version in Readme
@shd101wyy Would be great if you could give this a review. I am not certain what the next steps are to get the VSCode Markdown Preview to support Mermaid Let me know if I can help you out somehow! Really appreciate all the hard work that went into this, thank you! |
@shd101wyy bump 🙃 |
Hi @oneWaveAdrian , thank you for the PR. crossnote/src/markdown-engine/index.ts Line 815 in b64a355
10.8.0 version.
Also, the file located in https://github.com/shd101wyy/crossnote/tree/develop/dependencies/mermaid needs to be manually replaced with the one downloaded from:
👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a comment above ^^^ Thank you!
I don't know why the CI starts failing 😂
@shd101wyy Thanks for the review! Exchanged all files. Additionally fixed linter warnings flagged by CI, shouldn't have failed it though. Regarding the manual copy task for locally hosted scripts such as mermaid. I wonder if a script running post npm-build that copies the files from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 Thank you for updating mermaid.js and fixing the CI.
It seems like mermaid 10.9.0 just released. I will update it accordingly afterward. That is my bad. I haven't had much time on this project.
Of course, it will be great if we could have a script for automatically downloading all the scripts 👍
Closes #90
Changelog