Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix few issues with webpack@4 #134

Merged
merged 3 commits into from
Apr 7, 2018
Merged

fix few issues with webpack@4 #134

merged 3 commits into from
Apr 7, 2018

Conversation

mastilver
Copy link
Contributor

@mastilver mastilver commented Mar 29, 2018 •
edited
Loading

closes #128

@mastilver mastilver mentioned this pull request Mar 29, 2018
Closed
andriijas
andriijas approved these changes Mar 30, 2018
View reviewed changes
Copy link
Contributor

@andriijas andriijas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I glanced thought the file changes, looks good. I dont have time to test in real project right now unfortunately. Thanks for taking the time to fix this!

@codecov-io
Copy link

codecov-io commented Mar 30, 2018 •
edited
Loading

Codecov Report

Merging #134 into master will increase coverage by 5.1%.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #134     +/-   ##
=======================================
+ Coverage   94.89%   100%   +5.1%     
=======================================
  Files           2      2             
  Lines          98     98             
=======================================
+ Hits           93     98      +5     
+ Misses          5      0      -5
Impacted Files Coverage Δ
lib/plugin.js 100% <100%> (+5.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 052970e...2a55736. Read the comment docs.

@mastilver mastilver force-pushed the finalise-webpack-4 branch from 53f3bdd to b5efe37 Compare April 3, 2018 18:21
@mastilver mastilver force-pushed the finalise-webpack-4 branch from b5efe37 to 5fdbadc Compare April 7, 2018 13:18
mastilver added 2 commits April 7, 2018 15:49
@mastilver
test: reduce number of iterations
b70ac2d 
There should no longer be any race condition possible, so it's pretty safe
even if it could prevent the same issue not to be spotted
@mastilver
fix: webpack@3 plugin hook name
2a55736
@mastilver mastilver merged commit 5f5413d into master Apr 7, 2018
@mastilver mastilver deleted the finalise-webpack-4 branch April 7, 2018 17:01
@amir20
Copy link

amir20 commented Apr 7, 2018

Woohoo 🎊 I have been waiting for this. Any plans to release to npm soon?

@mastilver
Copy link
Contributor Author

mastilver commented Apr 7, 2018 •
edited
Loading

YES!!! Today hopefully, I need to double check if we need anything else... :)

@mastilver
Copy link
Contributor Author

v2 released

@dependencies dependencies bot mentioned this pull request Apr 9, 2018
Merged
@mastilver mastilver mentioned this pull request Apr 11, 2018
Closed
@mastilver mastilver mentioned this pull request Apr 27, 2018
Closed
@rposborne rposborne mentioned this pull request Jul 11, 2018
Merged
8 tasks
@dependabot-preview dependabot-preview bot mentioned this pull request Jun 5, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andriijas andriijas andriijas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mastilver @codecov-io @amir20 @andriijas