feat: Added ability to adjust plugin processAssets hook stage (#262) #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomlagier
commented
Apr 30, 2021
README.md
Outdated
| beforeEmit.tap('BatmanPlugin', (manifest) => { | ||
| return { ...manifest, name: 'hello' }; | ||
| }) | ||
| beforeEmit.tap("BatmanPlugin", (manifest) => { |
There was a problem hiding this comment.
This is from the lint commit hook.
|
@tomlagier thanks for opening this PR. I'm good with the concept with one caveat: I'd like to rename the option to |
shellscape
force-pushed
the
master
branch
3 times, most recently
from
4338db4 to
a93ca8c
Compare
|
Sounds good, will get those updates in today. |
tomlagier
force-pushed
the
tomlagier/add-processAssets-stage-option
branch
from
3abf43a to
300000b
Compare
|
Updated the PR, but I was having some lint & TS errors in untouched files. |
|
That's strange. Just checked master and it's looking OK. |
shellscape
force-pushed
the
tomlagier/add-processAssets-stage-option
branch
from
300000b to
ba07ca9
Compare
|
This https://github.com/shellscape/webpack-manifest-plugin/runs/4777081149?check_suite_focus=true#step:11:92 is why CI was failing. I'll clean this up and push to your branch so this can be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.
List any relevant issue numbers: #262
Description
This PR adds the ability to modify the
processAssetsstage that theWebpackManifestPluginruns under. Currently, it is hard-coded toInfinity, which means that it will always run last in theprocessAssetsstack. If we want to do some async behavior based on the output of the manifest, we need to schedule a hook later in theprocessAssetsseries.This allows us to manually modify the stage the hook runs at by passing a
processAssetsStageoption. We can set it to, e.g.webpack.Compiler.PROCESS_ASSETS_STAGE_ANALYSEand then add our own plugin atPROCESS_ASSETS_STAGE_REPORT.